docs: delineate cert health-gating from re-issuance#262
Merged
Conversation
Record the boundary between the two cert-failure paths in the gateway controller, per the decision in #260: keep them separate rather than unified behind a single failure detector. Add a short comment at each call site stating the split and why: - Health-gating (evaluateListenerCertHealth) is read-only and gates on any unusable cert. - Fast-track re-issuance (reissueFailedCertificate) mutates and fires only on cert-manager hard-fail (LastFailureTime); expired or missing certs recover via renewal or the isNew path instead. No behavior change; comments only.
ecv
marked this pull request as ready for review
July 13, 2026 04:11
Contributor
Author
|
wow, its me suggesting a comment |
ecv
enabled auto-merge
July 13, 2026 19:07
scotwells
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Records the boundary between the two cert-failure paths in the gateway controller with a short comment at each call site. No behavior change — comments only.
evaluateListenerCertHealth, call site ~line 279): read-only, gates a listener on any unusable cert (Ready!=True, not-yet-valid, expired, missing secret, corrupt keypair).reissueFailedCertificate, call site ~line 950): mutates (delete + gateway annotation bump), fires only on cert-manager hard-fail (LastFailureTime). Expired/missing certs recover via renewal or the ensure loop'sisNewpath instead.Why
Resolves the decision in #260 — keep the two paths delineated rather than unified behind a single failure detector. Full rationale and the stuck-state verification are recorded on that issue. Summary:
LastFailureTimesignal should trigger the destructive delete-recreate.Test
go build+ relevantinternal/controllertests pass; no logic touched.Closes #260